Deprecate -spawn_service_timeout option #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spawn_entity.py script has two options for setting service timeouts: 1. '-timeout': Sets the duration to wait for all services to be ready 2. '-spawn_service_timeout': Sets the duration to wait for the spawn_entity service to be ready (1) is available in all ROS distros since Dashing (except Eloquent for some reason). (2) was introduced in Eloquent, and replaced (1) in Foxy as the way to control the timeout specifically for the spawn_entity service. This change deprecates (2) and assumes (1) is used for all service timeouts again. This change also adds smoke tests for the two options. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
|
@Karsten1987 and @chapulina, let me know what you think about this proposal to deprecate |
ivanpauno
approved these changes
Mar 29, 2021
Signed-off-by: Jacob Perron <[email protected]>
|
@ros-pull-request-builder retest this please |
Karsten1987
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spawn_entity.py script has two options for setting service timeouts:
(1) is available in all ROS distros since Dashing (except Eloquent for some reason).
(2) was introduced in Eloquent, and replaced (1) in Foxy as the way to control the timeout specifically for the spawn_entity service.
This change deprecates (2) and assumes (1) is used for all service timeouts again.
This change also adds smoke tests for the two options.
For reference,
-timeoutwas added in #1072 and #1073, and-spawn_service_timeoutwas added in #1090.