Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert id to string #22

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Convert id to string #22

merged 3 commits into from
Jul 19, 2019

Conversation

mistermult
Copy link
Contributor

@mistermult mistermult commented Jul 15, 2019 •
edited by Kukanani
Loading

  • Add a field object_id of type string, e.g. to track one object across multiple frames (tracking).
  • Modify type of (class) id to type string.

See my comment #18 (comment) for the rationale of the design.

@Kukanani Kukanani changed the title Add object_id of type string. Convert id to string Jul 19, 2019
@Kukanani
Copy link
Collaborator

Updated to only change the type of the id field based on discussion in #18.

Thanks for the PR!

@Kukanani Kukanani merged commit 866d02f into ros-perception:kinetic-devel Jul 19, 2019
@hakuturu583 hakuturu583 mentioned this pull request Aug 5, 2019
Closed
Kukanani added a commit that referenced this pull request Oct 4, 2019
@Kukanani
Revert "Convert id to string (#22)"
5b308dc 
This reverts commit 866d02f.
@Kukanani Kukanani mentioned this pull request Oct 4, 2019
Merged
Kukanani added a commit that referenced this pull request Oct 4, 2019
@Kukanani
Revert "Convert id to string (#22)"
82dda4a 
This reverts commit 866d02f.
Kukanani added a commit that referenced this pull request Apr 16, 2021
@Kukanani
Revert "Convert id to string (#22)"
4f476af 
This reverts commit 866d02f.
SteveMacenski pushed a commit that referenced this pull request Apr 16, 2021
@Kukanani
Bring noetic-devel branch back to compatibility with 0.0.1 tag (#57)
fd30ff6 
* Revert "add tracking ID to the Detection Message (#19)"

This reverts commit 0d20a43.

* Revert "Convert id to string (#22)"

This reverts commit 866d02f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistermult @Kukanani