Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nav2_gps_waypoint_follower_demo #16
add nav2_gps_waypoint_follower_demo #16
Changes from 5 commits
65505cc
7c3b0a0
601a0ba
a44cf18
cfeea73
d699a4c
f5865b8
d164d62
d895e3b
050e8e2
fd91fa2
05187c3
559485e
1c710c2
e5538d6
5fffd49
52e2797
23dd4da
e2fcc7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you uploading all of these files? Are these not provided by gazebo that you were just using? They'll be downloaded on use from gazebo index, you don't need to upload these here unless you created them or had to manually download them youself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of them are provided in
gazebo_models
but some are not, I think to ensure that gazebo world will properly launch its just better to provide all models used in the world file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones that are, can we not include them here? I don't think there's a need to duplicate everything, that's alot of "stuff" to clone. I thought by including a
model://
it would look in the model store and download new things if needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I know if Gazebo could not find a model it will then run to get models from gazebo_models and download them to
~/.gazebo/models
.Edit; Available models that are already in above repo, has been removed.