Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add melodic to the wiki. #240

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Add melodic to the wiki. #240

merged 2 commits into from
Jan 26, 2018

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette [email protected]

Signed-off-by: Chris Lalancette <[email protected]>
@mikaelarguedas
Copy link
Contributor

👍 to confirm everything is working as expected.
Though that means we should allocate time soon to hide EOL distros #204

@dhood
Copy link
Contributor

dhood commented Jan 25, 2018

@clalancette
Copy link
Contributor Author

can you do the equivalent of this change too please: https://github.com/ros-infrastructure/roswiki/pull/199/files#diff-341a3118916c3daca1f33b898ac77d7eR54

I didn't actually understand that bit. What is that supposed to signify? Am I just supposed to change it to n-turtle?

@dhood
Copy link
Contributor

dhood commented Jan 25, 2018

yeah people shouldn't be using m-turtle anymore because it has a name, but people will be allowed to use n-turtle if they want

@mikaelarguedas
Copy link
Contributor

mikaelarguedas commented Jan 25, 2018

can you do the equivalent of this change too please: https://github.com/ros-infrastructure/roswiki/pull/199/files#diff-341a3118916c3daca1f33b898ac77d7eR54

Yeah I thought about it, I didnt comment as I wasn't sure if it would make more sense to do it now or when we make the distro the default one. But maybe it makes more sense to update now like it was done for the Lunar

@clalancette
Copy link
Contributor Author

I ended up adding it now. I'm also happy to revert; just let me know.

@mikaelarguedas
Copy link
Contributor

LGTM, Leaving it up to @dhood to approve / merge / deploy

@dhood dhood merged commit 64fb632 into master Jan 26, 2018
@dhood dhood deleted the melodic branch January 26, 2018 18:48
@dhood dhood removed the in progress label Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants