Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make src install less verbose #675

Merged
merged 2 commits into from
May 6, 2019
Merged

fix: make src install less verbose #675

merged 2 commits into from
May 6, 2019

Conversation

daenny
Copy link

@daenny daenny commented Apr 9, 2019

I have some custom .rdmanifest which install from source. Now the script is always printed in terminal (even with rosdep -q)
I think, this should be debug information.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Though in general when running potentially arbitrary scripts I'd prefer them to be at least seen once. But yes if the user wants a quiet output then we should let them suppress this.

@tfoote
Copy link
Member

tfoote commented Apr 10, 2019

The CI appears to be failing due to python hard deprecating yaml_load we worked around the externally accessible instances in #651 but left some internal ones.

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #675   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files          30       30           
  Lines        2890     2890           
=======================================
  Hits         2173     2173           
  Misses        717      717
Impacted Files Coverage Δ
src/rosdep2/platforms/source.py 90.5% <100%> (ø) ⬆️
src/rosdep2/shell_utils.py 100% <100%> (ø) ⬆️
src/rosdep2/sources_list.py 85.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe63aaa...c7a76ef. Read the comment docs.

@daenny
Copy link
Author

daenny commented Apr 11, 2019

I added a commit which replaces the remaining yaml.load() with yaml.safe_load()

@tfoote
Copy link
Member

tfoote commented Apr 11, 2019

Thanks!

@tfoote tfoote mentioned this pull request May 3, 2019
@tfoote tfoote merged commit 8f24319 into ros-infrastructure:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants