Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias CentOS as RHEL #668

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Alias CentOS as RHEL #668

merged 1 commit into from
Apr 18, 2019

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 11, 2019

Following the same approach as was used to handle Linaro and Elementry.

Also move all platform alias registration after the regular platform registrations. These aliases call get_os_name_and_version, which behaves differently if the calling platform is registered.

Related to #667
Closes #366

Also move all platform alias registration after the regular platform
registrations. These aliases call `get_os_name_and_version`, which
behaves differently if the calling platform is registered.
@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #668 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   75.19%   75.18%   -0.01%     
==========================================
  Files          30       30              
  Lines        2890     2898       +8     
==========================================
+ Hits         2173     2179       +6     
- Misses        717      719       +2
Impacted Files Coverage Δ
src/rosdep2/platforms/debian.py 85.71% <100%> (ø) ⬆️
src/rosdep2/platforms/redhat.py 86.08% <77.77%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe63aaa...5d3bd65. Read the comment docs.

@cottsay cottsay self-assigned this Mar 12, 2019
Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to merge it yourself @cottsay, when you're ready.

@cottsay cottsay merged commit 86dcf07 into ros-infrastructure:master Apr 18, 2019
@cottsay cottsay deleted the centos_alias branch June 3, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address overlap of CentOS and RHEL
4 participants