fix py2.7 flake8 error reporting bug #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format_map is 3.2+ only
|
@Nickolaim FYI |
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 30 30
Lines 2880 2880
=======================================
Hits 2167 2167
Misses 713 713Continue to review full report at Codecov.
|
NikolausDemmel
added a commit
to NikolausDemmel/rosdep
that referenced
this pull request
Oct 27, 2018
wjwwood
pushed a commit
that referenced
this pull request
Nov 1, 2018
…e W504 (#636) * format_map is python 3.2 or later only (see also #602) * Ignore new pycodestyle rule W504 Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297
at-wat
pushed a commit
to at-wat/rosdep
that referenced
this pull request
Nov 15, 2018
…e W504 (ros-infrastructure#636) * format_map is python 3.2 or later only (see also ros-infrastructure#602) * Ignore new pycodestyle rule W504 Was introduced in PyCQA/pycodestyle#502 it seems. Makes travis on master fail https://travis-ci.org/ros-infrastructure/rosdep/jobs/445522297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_map is 3.2+ only
I found/tested this here: https://travis-ci.org/wjwwood/parse_cmake/builds/357160260?utm_source=github_status&utm_medium=notification