Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REP 151 Python 3 rewrite #201

Merged
merged 43 commits into from
Mar 30, 2020
Merged

REP 151 Python 3 rewrite #201

merged 43 commits into from
Mar 30, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 5, 2019

This is a draft of a rewrite of REP 151 now that more information is known about transitioning to Python 3 in ROS Noetic. This replaces PR #149.

dirk-thomas and others added 5 commits January 4, 2018 13:18
* Bilingual Python proposal

* Add catkin_python_policy, more about risks.
Signed-off-by: Chris Lalancette <[email protected]>
This is a rewrite of the REP-151 proposal for the requirements of ROS
Noetic.

Signed-off-by: Shane Loretz <[email protected]>
@sloretz sloretz self-assigned this Aug 5, 2019
Signed-off-by: Shane Loretz <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
sloretz and others added 3 commits August 7, 2019 09:50
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
sloretz and others added 2 commits August 7, 2019 09:58
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
Co-Authored-By: Marya Belanger <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
Co-Authored-By: Marya Belanger <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
Co-Authored-By: Marya Belanger <[email protected]>
sloretz and others added 2 commits August 7, 2019 11:35
Co-Authored-By: Marya Belanger <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
@sloretz
Copy link
Contributor Author

sloretz commented Mar 26, 2020

This PR is ready for another round of review

rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of typos

rep-0151.rst Outdated Show resolved Hide resolved
rep-0151.rst Outdated Show resolved Hide resolved
sloretz and others added 2 commits March 30, 2020 15:02
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
@sloretz sloretz merged commit e194c90 into master Mar 30, 2020
@sloretz sloretz deleted the rep151-noetic-rewrite branch March 30, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants