-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REP 151 Python 3 rewrite #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bilingual Python proposal * Add catkin_python_policy, more about risks.
Signed-off-by: Chris Lalancette <[email protected]>
This is a rewrite of the REP-151 proposal for the requirements of ROS Noetic. Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
dirk-thomas
reviewed
Aug 5, 2019
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
maryaB-osr
reviewed
Aug 7, 2019
maryaB-osr
reviewed
Aug 7, 2019
maryaB-osr
reviewed
Aug 7, 2019
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
maryaB-osr
reviewed
Aug 7, 2019
maryaB-osr
reviewed
Aug 7, 2019
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
maryaB-osr
reviewed
Aug 7, 2019
Co-Authored-By: Marya Belanger <[email protected]>
maryaB-osr
reviewed
Aug 7, 2019
Co-Authored-By: Marya Belanger <[email protected]>
maryaB-osr
reviewed
Aug 7, 2019
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
cclauss
reviewed
Aug 7, 2019
cclauss
reviewed
Aug 7, 2019
This was referenced Sep 23, 2019
This was referenced Nov 27, 2019
8 tasks
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
This PR is ready for another round of review |
dirk-thomas
reviewed
Mar 26, 2020
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
dirk-thomas
approved these changes
Mar 30, 2020
maryaB-osr
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of typos
Co-Authored-By: Marya Belanger <[email protected]>
Co-Authored-By: Marya Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of a rewrite of REP 151 now that more information is known about transitioning to Python 3 in ROS Noetic. This replaces PR #149.