Make filenames to be used as ignore markers configurable #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first I wasn't too bothered by this PR and I even just pushed up some basic test cases exercising it. But as I was getting ready to approve I started wondering what use cases there are for making this configurable. The inciting case was helpfully described in the accompanying catkin_tools pr which involves using a shared workspace with ROS 1 and ROS 2 packages and I'm not sure that I could ever endorse or recommend sharing a source space with two different build tools like catkin_tools and colcon. Once tests and linters are passing I think I default to accepting this change because it doesn't break anything in the default tooling but I'd like to get other opinions as well. |
nuclearsandwich
approved these changes
Mar 1, 2022
cottsay
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catkin_pkg ignores packages that include one of {CATKIN_IGNORE, COLCON_IGNORE, AMENT_IGNORE}. For catkin_tools (which utilizes functions from catkin_pkg), I would like to implement a behavior such that it will only ignore packages that include CATKIN_IGNORE (and not those that have COLCON_IGNORE/AMENT_IGNORE). This PR does not change any functionality, it only makes the set of ignore markers configurable via a keyword argument. Link to catkin_tools PR: catkin/catkin_tools#688