package templates for catkin_create_pkg #1
Conversation
|
made changes to validation, fixed __init__s (changed commits), changed template marker |
|
I was imagining that the validate methods are neither static nor have an argument. Wouldn't that be straight forward? |
|
My thinking is that PYthon offers ducktyping, and we can use that to In short, yes, instancemethods would be "straightforward", but not the On Thu, Sep 27, 2012 at 7:50 AM, Dirk Thomas [email protected]:
|
|
Can you extract the template from the Python code into a separate file? |
|
If you could also update the template to the latest catkin state that would be great. But I can also make them after merging. |
|
rebased to latest master, separated template strings into files. |
package templates for catkin_create_pkg
|
Please re-add the CMakeLists template (even if it might need changes in the future). But we need a working version of that script asap. |
|
I already re-added the CMakeLists.txt to branch templates in catkin. You If we put anything catkin-version dependent into catkin_pkg, we will regret On Wed, Oct 17, 2012 at 1:12 AM, Dirk Thomas [email protected]:
|
* `parse_package_string()` raises `InvalidPackage` exception with the package name in the message. This work is needed for [https://github.com/ros-infrastructure/rosdep/issues/598](https://github.com/ros-infrastructure/rosdep/issues/598) * Add filename to the InvalidPackage exception coming from `Package.validate()` * `InvalidPackage` has `msg` and`package_path` (#1) `InvalidPackage` exception has `msg`, `package_path` and defines `__str__()` Note that `parse_package_string()` catches `InvalidPackage` exception and sets the filename; it is needed because the functions that called in `_parse_package_string()` raise InvalidPackage exception without filename, e.g. `_get_node()` * Minor code review fixes - Use double quotes for string literals with single quotes inside - Use forward slash instead of backward slash in file path * Pass filename to functions that raise InvalidPackage Remove not used `_get_optional_node_value()` Remove try/except block that was adding filename to InvalidPackage exception * nipick: improve error message
* Enable flake8 for the project as a unit test. The test is copied from [https://github.com/ros-infrastructure/rosdep/blob/d31c5320b95f4e9ff6a0aad56a8531cb138fc079/test/test_flake8.py](https://github.com/ros-infrastructure/rosdep/blob/d31c5320b95f4e9ff6a0aad56a8531cb138fc079/test/test_flake8.py) Code re-formatted, fixed other issues raised by flake8 * Do not run flake8 test on Python 3.2 Add Python 3.6 to Travis CI * keep operator trailing * avoid aligned indentation * avoid aligned indentation * remove unnecessary parenthesis * avoid aligned indentation * remove old comment * conf.py doesn't exist * remove usage of format_map which is not available in Python 2.7 * remove usage of format_map which is not available in Python 2.7 * Include package name in error message (#212) * Include package name in error message * Wrapped package name in quotes for consistency * Add support for file attribution of license tag (#202) * InvalidPackage with package path (#209) * `parse_package_string()` raises `InvalidPackage` exception with the package name in the message. This work is needed for [https://github.com/ros-infrastructure/rosdep/issues/598](https://github.com/ros-infrastructure/rosdep/issues/598) * Add filename to the InvalidPackage exception coming from `Package.validate()` * `InvalidPackage` has `msg` and`package_path` (#1) `InvalidPackage` exception has `msg`, `package_path` and defines `__str__()` Note that `parse_package_string()` catches `InvalidPackage` exception and sets the filename; it is needed because the functions that called in `_parse_package_string()` raise InvalidPackage exception without filename, e.g. `_get_node()` * Minor code review fixes - Use double quotes for string literals with single quotes inside - Use forward slash instead of backward slash in file path * Pass filename to functions that raise InvalidPackage Remove not used `_get_optional_node_value()` Remove try/except block that was adding filename to InvalidPackage exception * nipick: improve error message * Fix flake8 issues (1 empty line instead of 2) for recently updated code
Added code on top of small extensions to master:
No more empy usage. Code is unit-tested and somewhat pep8 compliant
Again, I am not sure whether the generated comments in CMakeLists.txt are optimal, but I think something like this is necessary for many robotic students who do not know cmake.
A script to create packages will be added via a pull request on catkin