Skip to content

Commit

Permalink
traj_action: also expose params as args in download launch file
Browse files Browse the repository at this point in the history
So their values can be changed by users.
  • Loading branch information
gavanderhoorn committed Oct 5, 2021
1 parent 2b5b079 commit 8db3016
Showing 1 changed file with 33 additions and 2 deletions.
35 changes: 33 additions & 2 deletions industrial_robot_client/launch/robot_interface_download.launch
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,37 @@
<!-- robot_ip: IP-address of the robot's socket-messaging server -->
<arg name="robot_ip" doc="IP of the controller" />

<!-- Prior to https://github.com/ros-industrial/industrial_core/pull/271, the
joint_trajectory_action server ignored the state of the OEM server program
and essentially open-loop forwarded incoming trajectories to the other
nodes in industrial_robot_client.
The new behaviour is to monitor the OEM server programs and reject
incoming goals and abort active ones when needed.
Set this argument to true to revert back to the old behaviour.
If this argument is set to false, the new behaviour will be used.
-->
<arg name="ignore_motion_server_error" default="false"
doc="Should OEM controller state be monitored while accepting goals and during execution?" />

<!-- Some OEM server programs (state relays running on the OEM controller)
cannot (reliably) determine values for certain fields in RobotStatus
messages. Those fields should then be set to TriState::UNKNOWN by those
servers.
UNKNOWN is essentially treated like OFF (or FALSE) by the code which
monitors the OEM server program, so for those server programs which must
send UNKNOWN, the monitoring code will always detect errors and refuse to
execute any trajectories.
Set this parameter to true to avoid this with such OEM server programs,
at the cost of potentially accepting goals and attempting to execute them
even if the server program would not be able to actually do that.
-->
<arg name="consider_status_unknowns_ok" default="false"
doc="Should UNKNOWNs in RobotStatus messages be considered as OKs?" />

<!-- copy the specified IP address to the Parameter Server, for use by nodes below -->
<param name="/robot_ip_address" type="str" value="$(arg robot_ip)"/>

Expand All @@ -31,8 +62,8 @@

<!-- joint_trajectory_action: provides actionlib interface for high-level robot control -->
<node pkg="industrial_robot_client" type="joint_trajectory_action" name="joint_trajectory_action">
<param name="ignore_motion_server_error" type="bool" value="true" />
<param name="consider_status_unknowns_ok" type="bool" value="true" />
<param name="ignore_motion_server_error" type="bool" value="$(arg ignore_motion_server_error)" />
<param name="consider_status_unknowns_ok" type="bool" value="$(arg consider_status_unknowns_ok)" />
</node>

</launch>

0 comments on commit 8db3016

Please sign in to comment.