Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Travis template #337

Merged
merged 6 commits into from
Nov 30, 2018
Merged

Improve Travis template #337

merged 6 commits into from
Nov 30, 2018

Conversation

mathias-luedtke
Copy link
Member

  • clean-up
  • silence git clone
  • extended and commented template

@mathias-luedtke mathias-luedtke requested a review from 130s November 30, 2018 11:07
130s
130s requested changes Nov 30, 2018
View reviewed changes
Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Nice cleanup and addition. Just left a few inline comments that may need to be addressed.

@130s 130s merged commit 3d69c87 into ros-industrial:master Nov 30, 2018
@mathias-luedtke mathias-luedtke deleted the improve-template branch December 2, 2018 15:12
@130s 130s mentioned this pull request Dec 3, 2018
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@130s 130s 130s approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathias-luedtke @130s