Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #279 premature merge #313

Closed
wants to merge 1 commit into from
Closed

Conversation

130s
Copy link
Member

@130s 130s commented Aug 10, 2018

Reverts #279

@ipa-mdl I'm sorry, I thought I clarified the status in #279 (review). And previously there were PRs that were merged with WIP in the title.

Anyways, I'll make sure the status before merge for WIP from now on.

@mathias-luedtke
Copy link
Member

Reverting a PR does not clean-up the git log mess ;)
I was afraid of merging #279 as-is after #283.
Now we have 2b93722 and d5316aa in the tree, whereas the latter is an improved version of the first..
After reviewing the changes that the revert would undo, the (merged) code should be alright.

@130s 130s deleted the revert-279-feature/rerun_ci branch September 4, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants