fix the error handling in run_travis #265

mathias-luedtke · 2018-01-14T11:19:40Z

fixes #262

mathias-luedtke · 2018-01-14T16:37:56Z

@130s: please test

130s

ROS_DISTRO seems to be set in the config.

swri_profiler$ echo $ROS_DISTRO
kinetic
swri_profiler$ git branch -vv
* master 71ae85e [origin/master] Merge pull request #11 from pjreed/install-files
swri_profiler$ more .travis.yml
sudo: required 
dist: trusty 
language: generic 
compiler:
  - gcc
notifications:
  email:
    on_success: always
    on_failure: always
env:
  global:
    - USE_DEB=true
    - ROS_DISTRO="jade"
  matrix:
    - ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
    - ROS_REPOSITORY_PATH=http://packages.ros.org/ros-shadow-fixed/ubuntu
matrix:
  allow_failures:
    - env: ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
install:
  - git clone https://github.com/ros-industrial/industrial_ci.git .ci_config
script: 
  - source .ci_config/travis.sh
#  - source ./travis.sh  # Enable this when you have a package-local script 

swri_profiler$ ~/industrial_ci/industrial_ci/scripts/run_travis
Job 1: ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Job 2: ROS_REPOSITORY_PATH=http://packages.ros.org/ros-shadow-fixed/ubuntu
run all with ~/industrial_ci/industrial_ci/scripts/run_travis -
swri_profiler$ ~/industrial_ci/industrial_ci/scripts/run_travis -
Running job 1: ~/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_profiler/src/swri-robotics/swri_profiler  ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Testing /home/n130s/cws_profiler/src/swri-robotics/swri_profiler
ROS distro '' is not supported
Tests failed exit code '1'
Failed job 1: ~/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_profiler/src/swri-robotics/swri_profiler  ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
swri_profiler$ ~/industrial_ci/industrial_ci/scripts/run_travis . -
Running job 1: ~/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_profiler/src/swri-robotics/swri_profiler  ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Testing /home/n130s/cws_profiler/src/swri-robotics/swri_profiler
ROS distro '' is not supported
Tests failed exit code '1'
Failed job 1: ~/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_profiler/src/swri-robotics/swri_profiler  ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu

swri_profiler$ ~/industrial_ci/industrial_ci/scripts/run_travis .
Job 1: ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Job 2: ROS_REPOSITORY_PATH=http://packages.ros.org/ros-shadow-fixed/ubuntu
run all with ~/industrial_ci/industrial_ci/scripts/run_travis -

Passing ROS_DISTRO from commandline seems to work.

swri_profiler$ ~/industrial_ci/industrial_ci/scripts/run_travis - -- ROS_DISTRO=jade

Does the script not read it from the .travis.yml?
If this is a requirement could you add to help or document?

mathias-luedtke · 2018-02-03T21:25:47Z

For some reason I have used "globals" instead of "global"..
Please try again.

130s · 2018-02-04T16:22:54Z

Hmm...

$ cd industrial_ci && git log -1
commit 1f8bbef230da217848b43738696ec0770a359abb
Author: Mathias Lüdtke <[email protected]>
Date:   Sat Feb 3 22:24:54 2018 +0100

    [run_travis] parse 'global' instead of 'globals'

$ ~/non_synced/cws_swri_profiler/src/swri-robotics/swri_profiler
$ git branch -vv
* master 71ae85e [origin/master] Merge pull request #11 from pjreed/install-files

$ ~/industrial_ci/industrial_ci/scripts/run_travis .
Job 1: ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Job 2: ROS_REPOSITORY_PATH=http://packages.ros.org/ros-shadow-fixed/ubuntu
run all with /home/n130s/industrial_ci/industrial_ci/scripts/run_travis -

$ ~/industrial_ci/industrial_ci/scripts/run_travis -
Traceback (most recent call last):
  File "/home/n130s/industrial_ci/industrial_ci/scripts/run_travis", line 170, in <module>
    main(os.path.abspath(os.path.dirname(__file__)), sys.argv)
  File "/home/n130s/industrial_ci/industrial_ci/scripts/run_travis", line 160, in main
    cmd = ' '.join(run_ci + [job_envs[i]])
TypeError: sequence item 2: expected string, tuple found

mathias-luedtke · 2018-02-04T17:11:38Z

Yeah, another bug ;)
Time for nosetests..

mathias-luedtke · 2018-06-03T22:23:24Z

@130s: While this PR does not fixes all issues, it fixes at least two. Can we track the other issue individually?

mathias-luedtke · 2018-06-03T22:49:54Z

@130s: swri_profiler works now ;)

130s · 2018-06-11T05:44:09Z

Gets stuck at the following line. Am I missing anything? Looks like run_travis is a Python script that doesn't import anything else from industrial_ci, I'm just calling it specifying its path.

RUN sed -i "/^# deb.multiverse/ s/^# //" /etc/apt/sources.list && apt-get update -qq && apt-get -qq install --no-install-recommends -y build-essential python-catkin-tools python-pip python-rosdep python-wstool ros-jade-catkin ssh-client && apt-get clean && rm -rf /var/lib/apt/lists/`

$ cd industrial_ci && git log -1                                                       
commit fce5f4a3ae51f48a6b142da2b5691f6c598bd538
Author: Mathias Lüdtke <[email protected]>
Date:   Mon Jun 4 00:48:58 2018 +0200

    fix tuple issue

$ cd swri_profiler
$ ~/link/industrial_ci/industrial_ci/scripts/run_travis -
Running job 1: /home/n130s/link/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_indicarice/src/swri-robotics/swri_profiler USE_DEB=true ROS_DISTRO="jade" ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Testing /home/n130s/cws_indicarice/src/swri-robotics/swri_profiler
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
Building image 'industrial-ci/jade/ubuntu:trusty':
FROM ubuntu:trusty

RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections

RUN apt-get update -qq     && apt-get -qq install --no-install-recommends -y apt-utils gnupg wget ca-certificates lsb-release

RUN echo "deb http://packages.ros.org/ros/ubuntu $(lsb_release -sc) main" > /etc/apt/sources.list.d/ros-latest.list
RUN apt-key adv --keyserver "hkp://ha.pool.sks-keyservers.net" --recv-key "0xB01FA116"     || { wget "https://raw.githubusercontent.com/ros/rosdistro/master/ros.key" -O - | apt-key add -; }

RUN sed -i "/^# deb.*multiverse/ s/^# //" /etc/apt/sources.list     && apt-get update -qq     && apt-get -qq install --no-install-recommends -y         build-essential         python-catkin-tools         python-pip         python-rosdep         python-wstool         ros-jade-catkin         ssh-client     && apt-get clean     && rm -rf /var/lib/apt/lists/*

^CTraceback (most recent call last):
  File "/home/n130s/link/industrial_ci/industrial_ci/scripts/run_travis", line 170, in <module>
    main(os.path.abspath(os.path.dirname(__file__)), sys.argv)
  File "/home/n130s/link/industrial_ci/industrial_ci/scripts/run_travis", line 164, in main
    proc.communicate(cmd)
  File "/usr/lib/python2.7/subprocess.py", line 797, in communicate
    self.wait()
  File "/usr/lib/python2.7/subprocess.py", line 1392, in wait
    pid, sts = _eintr_retry_call(os.waitpid, self.pid, 0)
  File "/usr/lib/python2.7/subprocess.py", line 476, in _eintr_retry_call
    return func(*args)
KeyboardInterrupt

Passing ROS_DISTRO manually but I still see jade, and it's stuck at the same place.

n130s@130s-p50:~/non_synced/cws_swri_profiler/src/swri_profiler$ ~/link/industrial_ci/industrial_ci/scripts/run_travis - -- ROS_DISTRO=kinetic
Running job 1: /home/n130s/link/industrial_ci/industrial_ci/scripts/run_ci /home/n130s/cws_indicarice/src/swri-robotics/swri_profiler USE_DEB=true ROS_DISTRO="jade" ROS_REPOSITORY_PATH=http://packages.ros.org/ros/ubuntu
Testing /home/n130s/cws_indicarice/src/swri-robotics/swri_profiler
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
Building image 'industrial-ci/jade/ubuntu:trusty':
FROM ubuntu:trusty

RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections

RUN apt-get update -qq     && apt-get -qq install --no-install-recommends -y apt-utils gnupg wget ca-certificates lsb-release

RUN echo "deb http://packages.ros.org/ros/ubuntu $(lsb_release -sc) main" > /etc/apt/sources.list.d/ros-latest.list
RUN apt-key adv --keyserver "hkp://ha.pool.sks-keyservers.net" --recv-key "0xB01FA116"     || { wget "https://raw.githubusercontent.com/ros/rosdistro/master/ros.key" -O - | apt-key add -; }

RUN sed -i "/^# deb.*multiverse/ s/^# //" /etc/apt/sources.list     && apt-get update -qq     && apt-get -qq install --no-install-recommends -y         build-essential         python-catkin-tools         python-pip         python-rosdep         python-wstool         ros-jade-catkin         ssh-client     && apt-get clean     && rm -rf /var/lib/apt/lists/*

mathias-luedtke · 2018-06-11T06:58:24Z

Passing ROS_DISTRO manually but I still see jade

Currently the values in .travis.yml take precedence. But overwriting but might be more intuitive..

Looks like run_travis is a Python script that doesn't import anything else from industrial_ci, I'm just calling it specifying its path.

Should work.

Gets stuck at the following line

This passes after 2min on my system.

mathias-luedtke · 2018-06-19T07:47:35Z

@130s: please try again

130s · 2018-06-23T05:13:18Z

Same steps in #265 (comment) worked on my computer! Merging.

fix the error handling in run_travis

d82394e

mathias-luedtke force-pushed the fix/run_travis-return-code branch from 2020846 to d82394e Compare January 14, 2018 16:54

mathias-luedtke requested a review from 130s February 2, 2018 07:42

130s reviewed Feb 3, 2018

View reviewed changes

[run_travis] parse 'global' instead of 'globals'

1f8bbef

fix tuple issue

fce5f4a

mathias-luedtke added 3 commits June 11, 2018 09:15

print globals in run_travis list

2f8c8ab

make run_travis arguments overwrite .travis.yml

0ada9ce

path for run_travis might point to config file directly

accf05d

mathias-luedtke mentioned this pull request Jun 19, 2018

added CI configs for Travis and Gitlab CI rosin-project/automatica18_scan_and_plan_demo#1

Merged

130s merged commit cba6908 into ros-industrial:master Jun 23, 2018

mathias-luedtke deleted the fix/run_travis-return-code branch February 7, 2019 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix the error handling in run_travis #265

fix the error handling in run_travis #265

mathias-luedtke commented Jan 14, 2018

mathias-luedtke commented Jan 14, 2018

130s left a comment

mathias-luedtke commented Feb 3, 2018

130s commented Feb 4, 2018

mathias-luedtke commented Feb 4, 2018 •

edited

Loading

mathias-luedtke commented Jun 3, 2018

mathias-luedtke commented Jun 3, 2018

130s commented Jun 11, 2018

mathias-luedtke commented Jun 11, 2018

mathias-luedtke commented Jun 19, 2018

130s commented Jun 23, 2018

fix the error handling in run_travis #265

fix the error handling in run_travis #265

Conversation

mathias-luedtke commented Jan 14, 2018

mathias-luedtke commented Jan 14, 2018

130s left a comment

Choose a reason for hiding this comment

mathias-luedtke commented Feb 3, 2018

130s commented Feb 4, 2018

mathias-luedtke commented Feb 4, 2018 • edited Loading

mathias-luedtke commented Jun 3, 2018

mathias-luedtke commented Jun 3, 2018

130s commented Jun 11, 2018

mathias-luedtke commented Jun 11, 2018

mathias-luedtke commented Jun 19, 2018

130s commented Jun 23, 2018

mathias-luedtke commented Feb 4, 2018 •

edited

Loading