Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defined but empty 'DOCKER_IMAGE' does not cause error. #296

Closed
130s opened this issue Jul 9, 2018 · 8 comments · Fixed by #617
Closed

Defined but empty 'DOCKER_IMAGE' does not cause error. #296

130s opened this issue Jul 9, 2018 · 8 comments · Fixed by #617
Assignees
@machinekoder

Comments

@130s
Copy link
Member

130s commented Jul 9, 2018

When passing empty DOCKER_IMAGE variable, CI continues although the intended docker image wasn't pulled. This makes debugging harder.
@130s 130s mentioned this issue Jul 9, 2018
Closed
@mathias-luedtke
Copy link
Member

Can you give more context, please?
DOCKER_IMAGE has multiple purposes, it might be used differently with regard to other settings.
In addition it would be good to know what the error looks like.

@130s 130s added the wrid18 label Jul 10, 2018
@130s
Copy link
Member Author

130s commented Jul 10, 2018

What happened to me was by mistake I substitute an empty variable like this. With this industrial_ci started building a default Docker image, which I was able to spot but I don't expect the same for the users.

DOCKER_IMAGE: $NOT_DEFINED

@mathias-luedtke
Copy link
Member

I see.
This case should be fixed here, because it just tests the length..

@machinekoder
Copy link
Contributor

Working on this for #wrid18

machinekoder added a commit to machinekoder/industrial_ci that referenced this issue Jul 11, 2018
@machinekoder
fix ros-industrial#296
1343d6c 
Check if DOCKER_IMAGE environment variable was set.
If it is set and empty, throw an error.
@machinekoder machinekoder mentioned this issue Jul 11, 2018
Closed
@130s
Copy link
Member Author

130s commented Jul 11, 2018

Maybe related to #212 btw.

@mathias-luedtke
Copy link
Member

#212 is not related.

@130s
Copy link
Member Author

130s commented Jul 11, 2018

#212 is not related.

You're right (I'm blaming my bad view on github from cellphone :/ ).

@130s 130s mentioned this issue Jul 11, 2018
Merged
130s pushed a commit to machinekoder/industrial_ci that referenced this issue Jan 3, 2019
@machinekoder @130s
fix ros-industrial#296
07b19dc 
Check if DOCKER_IMAGE environment variable was set.
If it is set and empty, throw an error.
@mathias-luedtke
Copy link
Member

Reviewing this issue, I would now opt for "wont fix".
DOCKER_IMAGE='' was not handled as error, because it means "use the default".
If we check this, then we have to a lot more variables.

@mathias-luedtke mathias-luedtke mentioned this issue Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machinekoder machinekoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve DOCKER_IMAGE detection mathias-luedtke/industrial_ci
4 participants
@mathias-luedtke @machinekoder @130s @gavanderhoorn