Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a Docker image already containing the target repo's master branch #241

Closed
130s opened this issue Dec 3, 2017 · 3 comments
Closed
Labels

Comments

@130s
Copy link
Member

130s commented Dec 3, 2017

I intend to use a Docker image where the source of the target repo is already cloned in, then it only needs to checkout the pull request's branch.
(I do this in order to save time as the target repo is gigabytes large (using Git LFS etc.) and CI often hits the CI's time limit.)

Currently this doesn't work as the workspace is read-only, so all attempts I've tried to update the target repo failed. I do not have a decisive opinion to an open PR #123

What will be the best way to do with industrial_ci?

@130s 130s added the question label Dec 3, 2017
@130s
Copy link
Member Author

130s commented Dec 3, 2017

A little more description for my usecase might be necessary.

A test in the target repo runs a downstream tests, and it requires a specific branch that's also available in a PR to the downstream repo. In other words, a PR to repo-A always comes with a PR to the downstream repo-B. To save the CI exec time, the aforementioned Docker image contains downstream pkgs as well.

I might have been wrong in my 1st post #241 (comment) in that the source of the target repo should be even cloned to inside of Docker without problems. So my real problem might be to update downstream code in the pre-built Docker image during industrial_ci process.

Anyways in a nutshell, how to change the code in the workspace during industrial_ci process?

Hope this makes sense and also I'm not making an XY problem..

@mathias-luedtke
Copy link
Member

mathias-luedtke commented Dec 3, 2017

Anyways in a nutshell, how to change the code in the workspace during industrial_ci process?

rosdep wstool?
If you need to overlay packages, you can even setup workspace chaining.

@mathias-luedtke
Copy link
Member

#361 will just overwrite the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants