Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMP0038 warning on CMake >= 3.0 #553

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix CMP0038 warning on CMake >= 3.0 #553

merged 1 commit into from
Apr 1, 2021

Conversation

VasilyF
Copy link
Contributor

@VasilyF VasilyF commented Mar 6, 2021

As of CMake 3.0 targets may not link to themselves when calling target_link_libraries (policy CMP0038), doing so will raise a warning and ignore targets linking to themselves. Trying to build on noetic, this is reported as an error.

Fix reflects PR to source: queezythegreat/arduino-cmake#143

@mikepurvis
Copy link
Member

Looks reasonable, thanks.

@mikepurvis mikepurvis merged commit 3ba9030 into ros-drivers:noetic-devel Apr 1, 2021
@VasilyF VasilyF deleted the rosserial_arduino_fix_CMP0038_warning branch April 3, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants