Feature/noetic python support #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably: - Add missing member initializations. - Add missing override specifiers. - Hacky cast for the 16 bit AVR float logic.
Closed
|
I guess this is still an omnibus in the way that #480 was, but at this point pragmatism should carry the day. Please also re-enable the python_socket test here, and if that passes clean on Noetic CI, then we're good to go: rosserial/rosserial_test/CMakeLists.txt Line 47 in 04ddab7 |
|
Thank you for the information. |
stertingen
reviewed
Aug 21, 2020
|
Thank you for checking and merging. |
|
Thank you for the work rebasing this branch and putting up the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are cherry picked by theseankelly to noetic-turtlebot branch branch from gcc7-fixes branch.