Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory execution does not stop when goal is aborted. #461

Closed
martiniil opened this issue Feb 13, 2020 · 1 comment
Closed

Trajectory execution does not stop when goal is aborted. #461

martiniil opened this issue Feb 13, 2020 · 1 comment

Comments

@martiniil
Copy link
Contributor

At least that is what I observed testing the joint_trajectory_controller.

Eventhough the goal is aborted, the trajectory stays and the controller tries to execute it. Imho this can lead to unpredictable behaviour.

        if (!checkStateTolerancePerJoint(state_joint_error_, joint_tolerances.state_tolerance))
        {
          if (verbose_)
          {
            ROS_ERROR_STREAM_NAMED(name_,"Path tolerances failed for joint: " << joint_names_[i]);
            checkStateTolerancePerJoint(state_joint_error_, joint_tolerances.state_tolerance, true);
          }
          rt_segment_goal->preallocated_result_->error_code =
          control_msgs::FollowJointTrajectoryResult::PATH_TOLERANCE_VIOLATED;
          rt_segment_goal->setAborted(rt_segment_goal->preallocated_result_);
          rt_active_goal_.reset();
          successful_joint_traj_.reset();
        }
@martiniil
Copy link
Contributor Author

Same as #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant