Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tf_prefix based on namespace (backport #1420) #1421

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 10, 2024

Fix test related with: #1060


This is an automatic backport of pull request #1420 done by Mergify.

Co-authored-by: Kees van Teeffelen <[email protected]>
(cherry picked from commit 950c9c1)
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.72%. Comparing base (b9816b5) to head (4f8730c).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...ive_controller/test/test_diff_drive_controller.cpp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1421      +/-   ##
==========================================
- Coverage   66.73%   66.72%   -0.01%     
==========================================
  Files         113      113              
  Lines       13214    13216       +2     
  Branches     8150     8152       +2     
==========================================
+ Hits         8818     8819       +1     
  Misses       1442     1442              
- Partials     2954     2955       +1     
Flag Coverage Δ
unittests 66.72% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 73.15% <100.00%> (+0.09%) ⬆️
...ive_controller/test/test_diff_drive_controller.cpp 63.87% <33.33%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 7a2ad46 into humble Dec 10, 2024
10 of 11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1420 branch December 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants