Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Code coverage + pre-commit #1057

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 23, 2024

  • Use coverage workflows from ros2_control_ci
  • Use pre-commit workflow from ros2_control_ci (combines old format and lint job)
  • Fix pre-commit errors
  • Exclude manuel from codespell 😄

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.72%. Comparing base (9f7e9e9) to head (af16929).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1057       +/-   ##
===========================================
- Coverage   47.71%   34.72%   -12.99%     
===========================================
  Files          41       58       +17     
  Lines        3871     7570     +3699     
  Branches     1833     4763     +2930     
===========================================
+ Hits         1847     2629      +782     
- Misses        751     1553      +802     
- Partials     1273     3388     +2115     
Flag Coverage Δ
unittests 34.72% <ø> (-12.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 99 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor Manuel is now excluded :(

@bmagyar bmagyar merged commit 00172ab into ros-controls:master Feb 27, 2024
11 of 12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
(cherry picked from commit 00172ab)

# Conflicts:
#	.github/workflows/ci-coverage-build-humble.yml
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-ros-lint.yml
#	.pre-commit-config.yaml
mergify bot pushed a commit that referenced this pull request Feb 27, 2024
(cherry picked from commit 00172ab)

# Conflicts:
#	.github/workflows/ci-coverage-build-humble.yml
#	.github/workflows/ci-coverage-build-iron.yml
#	.github/workflows/ci-coverage-build.yml
#	.github/workflows/ci-ros-lint.yml
bmagyar pushed a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants