Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the spawner to support full wildcard parameter entries (backport #1933) #1939

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

Fixes #1932


This is an automatic backport of pull request #1933 done by Mergify.

This comment was marked as outdated.

@mergify mergify bot added the conflicts label Dec 13, 2024
@saikishor saikishor force-pushed the mergify/bp/humble/pr-1933 branch from 1a2b768 to 36eeeea Compare December 13, 2024 10:43
@saikishor saikishor force-pushed the mergify/bp/humble/pr-1933 branch from 36eeeea to bd29641 Compare December 13, 2024 10:45
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 46.51163% with 23 lines in your changes missing coverage. Please review.

Project coverage is 62.95%. Comparing base (5bce7bf) to head (a21a733).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/test/test_spawner_unspawner.cpp 36.11% 3 Missing and 20 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1939      +/-   ##
==========================================
- Coverage   63.01%   62.95%   -0.06%     
==========================================
  Files         109      109              
  Lines       12450    12493      +43     
  Branches     8445     8478      +33     
==========================================
+ Hits         7845     7865      +20     
- Misses        842      845       +3     
- Partials     3763     3783      +20     
Flag Coverage Δ
unittests 62.95% <46.51%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 81.81% <100.00%> (+0.86%) ⬆️
controller_manager/test/test_spawner_unspawner.cpp 52.82% <36.11%> (-1.07%) ⬇️

@christophfroehlich christophfroehlich merged commit 38a5600 into humble Dec 13, 2024
12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1933 branch December 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants