Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sensors also export state interfaces of joints #1885

Merged
merged 10 commits into from
Dec 9, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 24, 2024

  • Let sensor export also state interfaces of joints
  • Fix returned no state interfaces warning

needed for ros-controls/ros2_control_demos#653

@christophfroehlich christophfroehlich changed the title Let sensor export also state interfaces of joints Let sensors also export state interfaces of joints Nov 24, 2024
saikishor
saikishor previously approved these changes Nov 25, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

hardware_interface/src/resource_manager.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
saikishor previously approved these changes Nov 25, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (3d57fc8) to head (ab0311d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...dware_interface/test/test_component_interfaces.cpp 93.87% 3 Missing ⚠️
...ce/include/hardware_interface/sensor_interface.hpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   87.83%   87.77%   -0.06%     
==========================================
  Files         122      122              
  Lines       12926    12978      +52     
  Branches     1153     1156       +3     
==========================================
+ Hits        11353    11391      +38     
- Misses       1148     1159      +11     
- Partials      425      428       +3     
Flag Coverage Δ
unittests 87.77% <93.22%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/resource_manager.cpp 73.30% <ø> (ø)
...e/test/test_component_interfaces_custom_export.cpp 89.16% <100.00%> (-0.09%) ⬇️
...ce/include/hardware_interface/sensor_interface.hpp 94.00% <87.50%> (-1.35%) ⬇️
...dware_interface/test/test_component_interfaces.cpp 96.36% <93.87%> (-1.28%) ⬇️

... and 1 file with indirect coverage changes

bmagyar
bmagyar previously approved these changes Dec 4, 2024
saikishor
saikishor previously approved these changes Dec 5, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

Maybe we don't need these debug prints

hardware_interface/test/test_component_interfaces.cpp Outdated Show resolved Hide resolved
hardware_interface/test/test_component_interfaces.cpp Outdated Show resolved Hide resolved
hardware_interface/test/test_component_interfaces.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
@bmagyar bmagyar merged commit d40377d into master Dec 9, 2024
13 of 18 checks passed
@bmagyar bmagyar deleted the sensor-joints branch December 9, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants