-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let sensors also export state interfaces of joints #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM
Co-authored-by: Sai Kishor Kothakota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
- Coverage 87.83% 87.77% -0.06%
==========================================
Files 122 122
Lines 12926 12978 +52
Branches 1153 1156 +3
==========================================
+ Hits 11353 11391 +38
- Misses 1148 1159 +11
- Partials 425 428 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8c979e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
Maybe we don't need these debug prints
Co-authored-by: Sai Kishor Kothakota <[email protected]>
needed for ros-controls/ros2_control_demos#653