[ros2_control_node] Add the realtime_tools lock_memory method to prevent page faults #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
fmauch,
mamueluth,
mcbed,
moriarty and
olivier-stasse
saikishor
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 120 120
Lines 12224 12226 +2
Branches 1093 1093
=======================================
+ Hits 10709 10711 +2
Misses 1125 1125
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
reviewed
Oct 30, 2024
saikishor
force-pushed
the
lock_memory
branch
from
ce5be80 to
3d9a4f4
Compare
bmagyar
reviewed
Oct 31, 2024
bmagyar
previously approved these changes
Oct 31, 2024
bmagyar
added
backport-humble
Co-authored-by: Bence Magyar <[email protected]>
bmagyar
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
binary-testing build should be green after ros/rosdistro#43337 is merged
saikishor
added a commit
to pal-robotics-forks/ros2_control
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lock_memory to avoid page faults and lock the memory at the beginning to physical RAM