Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Handle other exceptions while loading the controller plugin (backport #1731) #1733

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 30, 2024

As of now, we are only handling the exceptions of the pluginlib::CreateClassException there are many other exceptions defined by the pluginlib, that might be also interesting to catch. I'm using std::exception as the main PluginlibException is derived from std::runtime_error and which is derived from std::exception, and this gives us way to be generic (https://github.com/ros/pluginlib/blob/jazzy/pluginlib/include/pluginlib/exceptions.hpp#L43)


This is an automatic backport of pull request #1731 done by Mergify.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.27%. Comparing base (5bf0da5) to head (7e91913).
Report is 2 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1733   +/-   ##
=======================================
  Coverage   62.27%   62.27%           
=======================================
  Files         105      105           
  Lines       11327    11330    +3     
  Branches     7926     7927    +1     
=======================================
+ Hits         7054     7056    +2     
- Misses        815      816    +1     
  Partials     3458     3458           
Flag Coverage Δ
unittests 62.27% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 66.30% <0.00%> (+<0.01%) ⬆️

@christophfroehlich christophfroehlich force-pushed the mergify/bp/humble/pr-1731 branch from 0fa410b to b8187f2 Compare August 30, 2024 16:34
@bmagyar bmagyar merged commit f3e7db6 into humble Oct 10, 2024
10 of 11 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1731 branch October 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants