-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate IDs which can be used to reference plans #93
Open
rorybyrne
wants to merge
11
commits into
main
Choose a base branch
from
63/plan-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this commit do? ========================= * changes all references to "commit" to be "plan" instead * updates "plan_service" to reference plans instead of commits * fixes a bug where plans would be filtered using the wrong variable Why are we doing this? ====================== * To avoid confusion around terminology - a plan is not the same as a commit Notes =====
What does this commit do? ========================= * switches from repository model back to project * renames all tests to work with projectionist.vim * Removes @decorators from commands, and starts putting them on service methods again Why are we doing this? ====================== * the design of repository-model -> command decorators was bad
What does this commit do? ========================= * Adds a "migration_service.py" file which can migrate planfiles from the old format to the new * Adds a "migrate.py" command which allows the user to migrate their plans * Adds a hook in the CLI which will check for required migration and prompt the user. Why are we doing this? ====================== * To migrate old plans to the new format (with "id")
Closes #63 |
What does this commit do? ========================= * Adds new targets to the Justfile for linting.
What does this commit do? ========================= * Adds a `--id` flag to `gp commit`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Broadly, this PR introduces IDs/labels for plans, so that they can be referenced easily (e.g.
git-plan commit --id GP-123
)Some highlights:
Why are we doing this?
Testing performed
Known issues