Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutate updates #156

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Mutate updates #156

merged 4 commits into from
Feb 5, 2025

Conversation

JauntyJJS
Copy link
Contributor

Update the data_format function in normals.R to use dplyr::across instead of dplyr::mutate_at.
Added some file to ignore (.Rbuildignore) so that devtools::check() will give less notes and warnings
Added some file for git to ignore (.gitignore)

Copy link
Member

@steffilazerte steffilazerte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JauntyJJS!
This looks great!
One change I'd like to request that you don't add the .html and .R files from the vignettes folder. They should have been gitignore (but I see now that the gitignore is gitignored 🤦🏼, I'll fix that 😁

Thanks again!

@JauntyJJS
Copy link
Contributor Author

@steffilazerte I have removed the .html and .R files from the vignettes folder

@steffilazerte steffilazerte merged commit ac947bb into ropensci:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants