Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Mac install problem introduced by new chromedriver binaries for Mac M1 #26

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

JeffreyBLewis
Copy link
Contributor

As described in #25, the introduction of new binaries for Mac M1 was leading to both the mac64 and mac64-m1 chromedriver binaries being downloaded and the m1 binary being installed on Mac Intel machines (at least on mine :)). This pull request adds mac64-m1 to the list of platforms in chromedriver.yml and adds a few lines to chrome.R that determine if the mac64 or mac64-m1 binary is needed and then installs the correct binary.

I haven't tested this on an M1 machine, but it does work on (my) mac64 (Intel) platform.

I tried to address the issue in a way to involved the least amount of change. Arguably, it would be better to provide a more elegant fix that would generally allow for the possibility that one platform name could be a substring of another which is the root cause of the current problem.

@aaronrudkin
Copy link

Are there any suggestions for what @JeffreyBLewis or I could do to get this merged? The Travis error above is a CI configuration issue, not an issue with the code. Either of us would be happy to make changes to syntax or approach if it meant getting this patch merged.

@priessdev
Copy link

Hi, new R/ Rselenium user here. Like others, I experienced the chrome / driver problems related to using Rselenium in Mac OS described in various threads. I see that people have developed workarounds and that proposed code has been written but I am unsure what steps to take right now. For example, not sure how to use the proposed code changes that I can see in GitHub. Can someone point to a solid solution that will get me going?

@JeffreyBLewis
Copy link
Contributor Author

@priessdev, you have a number of options and there are a number of possible issues that you may be encountering. If you are you are using an Intel-based Mac, you can try my patched version of wdman:

unlink("~/Library/Application Support/binman_chromedriver", recursive=TRUE)
remotes::install_github("JeffreyBLewis/wdman", ref="iss25", force=TRUE)

This will get the current version of RSelenium working with Chrome in many cases. However, there are other RSelenium issues that you may encounter that this wdman fix will not resolve. The attached document describes various approaches to working through several of those issues if the above does not get you squared away:

RSelenium-troubleshooting.pdf

@priessdev
Copy link

priessdev commented May 16, 2021

@priessdev, you have a number of options and there are a number of possible issues that you may be encountering. If you are you are using an Intel-based Mac, you can try my patched version of wdman:

unlink("~/Library/Application Support/binman_chromedriver", recursive=TRUE)
remotes::install_github("JeffreyBLewis/wdman", ref="iss25", force=TRUE)

This will get the current version of RSelenium working with Chrome in many cases. However, there are other RSelenium issues that you may encounter that this wdman fix will not resolve. The attached document describes various approaches to working through several of those issues if the above does not get you squared away:

RSelenium-troubleshooting.pdf

Hi Jeffrey, worked like a charm! Thank you.

@dmurdoch
Copy link

Just had another Chrome update cause the issue #25 problems again. This time I found PR #26, and it works. Thanks! Hopefully it can be merged eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants