Fixing Mac install problem introduced by new chromedriver binaries for Mac M1 #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #25, the introduction of new binaries for Mac M1 was leading to both the mac64 and mac64-m1 chromedriver binaries being downloaded and the m1 binary being installed on Mac Intel machines (at least on mine :)). This pull request adds
mac64-m1
to the list of platforms inchromedriver.yml
and adds a few lines tochrome.R
that determine if the mac64 or mac64-m1 binary is needed and then installs the correct binary.I haven't tested this on an M1 machine, but it does work on (my) mac64 (Intel) platform.
I tried to address the issue in a way to involved the least amount of change. Arguably, it would be better to provide a more elegant fix that would generally allow for the possibility that one platform name could be a substring of another which is the root cause of the current problem.