Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call helper file "setup" #184

Merged
merged 3 commits into from
Oct 26, 2020
Merged

call helper file "setup" #184

merged 3 commits into from
Oct 26, 2020

Conversation

maelle
Copy link
Member

@maelle maelle commented Oct 20, 2020

Fix #183

@maelle maelle requested a review from sckott October 20, 2020 12:18
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files          36       36           
  Lines        1535     1535           
=======================================
  Hits         1217     1217           
  Misses        318      318           
Impacted Files Coverage Δ
R/check_cassette_names.R 90.90% <ø> (ø)
R/vcr_setup.R 46.15% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e4bc1...1d0b4ce. Read the comment docs.

Copy link
Collaborator

@sckott sckott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just a comment on the news file change

NEWS.md Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Oct 21, 2020

Wondering whether this was the best change r-lib/testthat#1206 (comment)

@maelle
Copy link
Member Author

maelle commented Oct 21, 2020

@maelle maelle requested a review from sckott October 21, 2020 11:18
@sckott sckott added this to the v0.6 milestone Oct 26, 2020
@sckott sckott merged commit be3ab9c into master Oct 26, 2020
@sckott sckott deleted the helper-setup branch October 26, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use_vcr() create a file called setup not helper
3 participants