Exclude function signatures from tar_format() output strings to reduc…

…e the size of pipeline metadata (#1390).

DESCRIPTION

@@ -12,7 +12,7 @@ Description: Pipeline tools coordinate the pieces of computationally
   The methodology in this package
   borrows from GNU 'Make' (2015, ISBN:978-9881443519)
   and 'drake' (2018, <doi:10.21105/joss.00550>).
-Version: 1.9.1.9008
+Version: 1.9.1.9009
 License: MIT + file LICENSE
 URL: https://docs.ropensci.org/targets/, https://github.com/ropensci/targets
 BugReports: https://github.com/ropensci/targets/issues

NEWS.md

@@ -1,10 +1,11 @@
-# targets 1.9.1.9008
+# targets 1.9.1.9009
 
 ## Invalidating changes
 
 These changes invalidate certain targets in a pipeline and cause them to rerun on the next `tar_make()`.
 
 * Exclude function signatures from `tar_repository_cas()` output strings to reduce the size of pipeline metadata (#1390).
+* Exclude function signatures from `tar_format()` output strings to reduce the size of pipeline metadata (#1390).
 
 ## Summary of performance gains
 

R/class_pipeline.R

@@ -339,6 +339,7 @@ pipeline_validate <- function(pipeline) {
 pipeline_validate_lite <- function(pipeline) {
   tar_assert_inherits(pipeline, "tar_pipeline", msg = "invalid pipeline.")
   tar_assert_correct_fields(pipeline, pipeline_new)
+  tar_assert_target_name_case(pipeline_get_names(pipeline))
   pipeline_validate_conflicts(pipeline)
 }
 

R/class_store_format_custom.R

@@ -9,12 +9,13 @@ store_class_format_format_custom <- c(
   "tar_store"
 )
 
-store_format_custom_field <- function(format, pattern, default) {
+store_format_custom_field <- function(format, pattern, default, prefix) {
   out <- base64url::base64_urldecode(keyvalue_field(format, pattern))
   if ((length(out) < 1L) || !any(nzchar(out))) {
-    out <- default
+    return(default)
+  } else {
+    return(paste0(prefix, out))
   }
-  out
 }
 
 #' @export

R/class_store_format_custom_methods.R

@@ -4,32 +4,38 @@ store_format_custom_methods_init <- function(format) {
     read = store_format_custom_field(
       format = format,
       pattern = "^read=",
-      default = store_format_custom_default_read()
+      default = store_format_custom_default_read(),
+      prefix = "function(path) "
     ),
     write = store_format_custom_field(
       format = format,
       pattern = "^write=",
-      default = store_format_custom_default_write()
+      default = store_format_custom_default_write(),
+      prefix = "function(object, path) "
     ),
     marshal = store_format_custom_field(
       format = format,
       pattern = "^marshal=",
-      default = store_format_custom_default_marshal()
+      default = store_format_custom_default_marshal(),
+      prefix = "function(object) "
     ),
     unmarshal = store_format_custom_field(
       format = format,
       pattern = "^unmarshal=",
-      default = store_format_custom_default_unmarshal()
+      default = store_format_custom_default_unmarshal(),
+      prefix = "function(object) "
     ),
     convert = store_format_custom_field(
       format = format,
       pattern = "^convert=",
-      default = store_format_custom_default_convert()
+      default = store_format_custom_default_convert(),
+      prefix = "function(object) "
     ),
     copy = store_format_custom_field(
       format = format,
       pattern = "^copy=",
-      default = store_format_custom_default_copy()
+      default = store_format_custom_default_copy(),
+      prefix = "function(object) "
     )
   )
 }

R/tar_format.R

@@ -76,8 +76,9 @@
 #'   See the "Format functions" section for specific requirements.
 #'   If `NULL`, the `unmarshal` argument defaults to just
 #'   returning the original object without any modifications.
-#' @param convert The `convert` argument is a function
-#'   that accepts the object returned by the command of the target
+#' @param convert The `convert` argument is a function with a single argument
+#'   named `object`.
+#'   It accepts the object returned by the command of the target
 #'   and changes it into an acceptable format (e.g. can be
 #'   saved with the `read` function). The `convert`
 #'   ensures the in-memory copy
@@ -88,8 +89,9 @@
 #'   `error = "null"` in [tar_target()] or [tar_option_set()]).
 #'   If `NULL`, the `convert` argument defaults to just
 #'   returning the original object without any modifications.
-#' @param copy The `copy` argument is a function
-#'   that accepts the object returned by the command of the target
+#' @param copy The `copy` argument is a function with a single function
+#'   named `object`.
+#'   It accepts the object returned by the command of the target
 #'   and makes a deep copy in memory. This method does is relevant
 #'   to objects like `data.table`s that support in-place modification
 #'   which could cause unpredictable side effects from target
@@ -231,10 +233,11 @@ tar_format <- function(
 }
 
 tar_format_field <- function(key, value) {
-  encoded <- if_any(
-    is.null(value),
-    "",
-    base64url::base64_urlencode(tar_deparse_safe(value))
-  )
-  paste0(key, "=", encoded)
+  if (is.null(value)) {
+    return(paste0(key, "="))
+  }
+  if (is.function(value)) {
+    value <- body(value)
+  }
+  paste0(key, "=", base64url::base64_urlencode(tar_deparse_safe(value)))
 }

R/tar_target.R

@@ -198,7 +198,15 @@
 #'   can refer to this name symbolically to induce a dependency relationship:
 #'   e.g. `tar_target(downstream_target, f(upstream_target))` is a
 #'   target named `downstream_target` which depends on a target
-#'   `upstream_target` and a function `f()`. In addition, a target's
+#'   `upstream_target` and a function `f()`.
+#'
+#'   In most cases, The target name is the name of its local data file
+#'   in storage. Some file systems are not case sensitive, which means
+#'   converting a name to a different case may overwrite a different target.
+#'   Please ensure all target names have unique names when converted to
+#'   lower case.
+#'
+#'   In addition, a target's
 #'   name determines its random number generator seed. In this way,
 #'   each target runs with a reproducible seed so someone else
 #'   running the same pipeline should get the same results,

R/utils_assert.R

@@ -871,3 +871,22 @@ tar_assert_meta <- function(store) {
     tar_throw_validate(message = message)
   }
 }
+
+tar_assert_target_name_case <- function(names) {
+  index <- duplicated(tolower(names))
+  if (!any(index)) {
+    return()
+  }
+  problems <- paste(names[index], collapse = ", ")
+  message <- paste0(
+    "In most pipelines, a target name is the name of its data file in ",
+    "storage. Some file systems are not case sensitive, so targets ",
+    "should not have duplicate names when converting to lower case. ",
+    "Found problematic names: ",
+    problems
+  )
+  tar_warning(
+    message = message,
+    class = c("tar_condition_validate", "tar_condition_targets")
+  )
+}

tests/testthat/test-utils_assert.R

@@ -471,3 +471,11 @@ tar_test("tar_assert_identical()", {
     class = "tar_condition_validate"
   )
 })
+
+tar_test("tar_assert_target_name_case()", {
+  expect_silent(tar_assert_target_name_case(letters))
+  expect_warning(
+    tar_assert_target_name_case(c(letters, LETTERS)),
+    class = "tar_condition_validate"
+  )
+})