importFrom methods is. Resolves gp NOTE #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robinlovelace
approved these changes
Feb 12, 2021
| @@ -143,6 +143,7 @@ slope_matrices = function(m_xyz_split, fun = slope_matrix_weighted, ...) { | |||
| #' datasets. Default: `"bilinear"`. | |||
| #' @param fun The slope function to calculate per route, | |||
| #' `slope_matrix_weighted` by default. | |||
| #' @importFrom methods is | |||
There was a problem hiding this comment.
Aha, makes sense! Many thanks for a great fix 🎉 will aim to look at the other issues next week.
|
many thanks!! |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NOTE identified by
goodpractice::gp(see ropensci/software-review#420 (comment))methodsdependency: It looks likemethodsis a special case. Having a look at this more detailed documentation on namespacing and in particular the S4 section it looks like the workaround is to import themethodsfunctions you need in the function roxugen2 documentation.