Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid testthat deprecated features + upkeep #747

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

olivroy
Copy link

@olivroy olivroy commented Nov 27, 2024

Basically, this updates the Roxygen2 version and use "_PACKAGE" https://www.tidyverse.org/blog/2024/01/roxygen2-7-3-0/

  • Remove crayon from Suggests
  • Update GitHub actions with usethis::use_github_action() (remove pkgdown action, not needed due to Ropensci publishing site)
  • Use testthat 3rd edition
  • Remove testthat::with_mock() as it is now deprecated and replace it with testthat::local_mocked_bindings()
  • The larger change is to transition to snapshotting to verify output. I isolated that in separate commits. Basically, the idea is to use expect_snapshot(), and for testing knit_print(), I used cat() to only capture output.

I verified manually that the new output is the same as the old.

As you see, I didn't modify much under R/.

Happy to answer questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant