Avoid internal git-buf API where possible #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move them before git2r headers, use angle-brackets to differentiate public headers, and remove some extraneous includes. Signed-off-by: Elliott Sales de Andrade <[email protected]>
Signed-off-by: Elliott Sales de Andrade <[email protected]>
This reduces the need to use internal libgit2 functions. Signed-off-by: Elliott Sales de Andrade <[email protected]>
Signed-off-by: Elliott Sales de Andrade <[email protected]>
The public API is to use the `.ptr` struct entry directly. Signed-off-by: Elliott Sales de Andrade <[email protected]>
Signed-off-by: Elliott Sales de Andrade <[email protected]>
|
Thanks for fixing the git-buf usage and the libgit2 headers. I have a question regarding the angle-brackets. They affect the search path of the C pre-processor and since libgit2 is bundled within git2r, I'm curious about why this change? |
|
Technically they're both implementation defined, but in practice (gcc & msvc), the only difference is that quotes checks the current directory first (followed by The change is mostly a cosmetic one; when I see the angle brackets, I think it's external. Now, in this case it's not actually external, but it helps keep that connotation at least. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git-buf API is mostly internal to libgit2. Where an equivalent public API exists, this PR changes to those functions instead. This reduces the chances of breaking changes when updating libgit2 as there is less dependency on internals.
This PR is based on #336, so it looks a bit larger than it really is. The individual commits should be relatively straightforward though.