Add sleep to each try_again for Pubmed/entrez tests

Signed-off-by: Mathew W. McLean <[email protected]>
ropensci · Oct 8, 2024 · 7328319 · 7328319
1 parent 45842ed
commit 7328319
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/R/ReadPubMed.R b/R/ReadPubMed.R
@@ -120,6 +120,7 @@ GetPubMedByID <- function(id, db = "pubmed", ...){
   ## temp <- postForm(base.url, .params = parms)
   ## tdoc <- xmlParse(temp)
   temp <- POST(base.url, query = parms)
+  stop_for_status(temp)
   tdoc <- read_xml(temp)
 
   ## Note: directly using xpathApply on tdoc won't work if some results are

diff --git a/tests/testthat/test-pubmed.R b/tests/testthat/test-pubmed.R
@@ -49,18 +49,17 @@ test_that("LookupPubMedID successfully retrieves and add ID's'", {
 
 test_that("GetPubMedByID reading of years/months (#52)", {
   skip_if_offline("eutils.ncbi.nlm.nih.gov")
-  Sys.sleep(2)
-  try_again(3, bib <- GetPubMedByID("23891459"))
+  try_again(3, {Sys.sleep(2); bib <- GetPubMedByID("23891459")})
   expect_equal(bib$year, "2013")
   expect_equal(bib$month, "07")
 })
 
 test_that("GetPubMedByID: Multiple books parsed correctly #86",
 {
     skip_if_offline("eutils.ncbi.nlm.nih.gov")
-    Sys.sleep(2)
+
     ids <- c("33780208", "33764725")
     names(ids) <- c("geary2021variation", "brennan2021potential")
-    try_again(5, bib <- GetPubMedByID(ids))
+    try_again(3, {Sys.sleep(2); bib <- GetPubMedByID(ids)})
     expect_equal(unlist(bib$eprint), ids)
 })