Multisite fix #25
Multisite fix #25
Conversation
- Switch to treating the provided environment host as a suffix - Move things out of the stages loop that don't need to be there - Add a filter on the URL for any custom logic requirements
|
@swalkinshaw Thoughts on this PR? I'm happily using it in production on a multisite subdomain installation. |
| 'class' => 'environment-' . sanitize_html_class(strtolower($current_stage)), | ||
| ], | ||
| ]); | ||
| $url = apply_filters('bedrock/stage_switcher_url', rtrim($url, '/') . $_SERVER['REQUEST_URI'], $url, $stage); |
There was a problem hiding this comment.
Should the filter name just be the plugin name exactly? So either roots/wp-stage-switcher or wp-stage-switcher. I don't think bedrock should be part of it?
There was a problem hiding this comment.
I was using the format of the existing bedrock/stage_switcher_visibility filter, but I'm happy to change it
There was a problem hiding this comment.
Ah sorry, forgot about that. Okay this works 👍
|
Thanks @dotsam. We'll do a release soon |
|
@swalkinshaw Hi Scott, would it be possible to cut a new release now? I've had dev-master running on multisite and non-multisite installs for a while now without issue. |
|
@dotsam done, thank you for contributing! |
Fixes #24
I did end up taking the "treat the URL as a suffix" approach, rather than trying to guess and split the domain into parts. I believe this should handle all cases, but in cases where there isn't a match, it may produce an invalid URL.
As discussed, I've also added a filter for cases when the normal logic doesn't apply (primarily I'm thinking of production sites that have a unique domain, in which case the user will need to maintain their own mapping).
I've also removed the composer autoloader since there are no longer any external deps, and also tweaked the CSS selector for the admin bar icon to be more in-line with how WP Core targets things.