-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ssl provider: cloudflare-origin-ca #870
Conversation
b8728f8
to
91613af
Compare
Any update @swalkinshaw ? |
No, I'm undecided on this one. I don't know if Trellis should have a Cloudflare specific option like this built-in. |
No worries, really appreciate your updates through! |
perhaps publish it to ansible galaxy is a better idea Question: |
Good question, I think it would use Child templates. Right now there's an |
Extracted from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
Extract from roots/trellis#870
@tangrufus thanks, took a quick look at that and it looks great. This is one of the first 3rd party roles like this so it was interesting to see how the implementation went. Most of it looks fairly straightforward. Other than the playbook hack 😔 . Something like #830 might be able to help that. |
Other than #830, we need better way for galaxy roles to override Nginx templates. Telling users use templats in vendor doesn't feel right: nginx_wordpress_site_conf: vendor/roles/TypistTech.trellis-cloudflare-origin-ca/templates/wordpress-site.conf.child But it the only way I could think of. Adding to |
Yeah I did notice that and thought it wasn't ideal either but honestly I'm not so sure how much it matters. In any language with packages, it would be equivalent to |
What to do when another galaxy role need to extend |
Good question. I'm just not sure we can reasonably expect a solution for that. |
For current state of Trellis, would it be better to use regexp replace instead of jinja2 template override? |
Up to you ultimately. Usually I wouldn't like regexp for things like this, but at least the template output is predictable since it's not a manually created file. |
Usage:
This will generate and upload (to Cloudflare) a cert for
example.com,hi.example.com,bye.example.com
This is Origin CA not Universal SSL
close #868