Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Laravel Mix with Bud #2643

Merged
merged 52 commits into from
Nov 22, 2021
Merged

Replace Laravel Mix with Bud #2643

merged 52 commits into from
Nov 22, 2021

Conversation

kellymears
Copy link
Contributor

@kellymears kellymears commented Feb 28, 2021

No description provided.

@kellymears kellymears requested review from QWp6t and Log1x February 28, 2021 02:51
@kellymears kellymears self-assigned this Feb 28, 2021
@kellymears kellymears mentioned this pull request Feb 28, 2021
@retlehs retlehs changed the title @roots/sage build tooling Replace Laravel Mix with Bud Mar 2, 2021
@QWp6t
Copy link
Member

QWp6t commented Mar 16, 2021

It looks like Tailwind isn't working correctly. The configured classes aren't being included during compile, but all of the @apply stuff is.

I have confirmed that tailwind.config.js is loading during compile.

screenshots

image

image

image

@kellymears
Copy link
Contributor Author

kellymears commented Mar 25, 2021

@QWp6t I think this is almost 100% good to go. I don't think the base path is being set properly for relative css imports, but proxy/hmr/postcss/react all seem to be on their best behavior. File hashing works well, minification works well. It feels fast.

I will need to also try dropping some actual production dependencies. Out-of-the-box there is no runtime/vendor bundle generated as there are no deps to bundle.

  • Fix base path for relative urls in css
  • Confirm runtime / vendor bundles are correctly generated
  • Fix CI

@Jamiewarb
Copy link

Just chatting with Ben about this, and wanted to reach out and see if there's anything a potential contributor could help with for this to help get it over the line. Let me know if there's anything I can do to help ☺️

@retlehs retlehs self-requested a review October 22, 2021 00:42
@retlehs retlehs added this to the 10.0.0-beta.2 milestone Oct 22, 2021
Comment on lines +8 to +12
export const domReady = (onReady) => {
window.requestAnimationFrame(function check() {
document.body ? onReady() : window.requestAnimationFrame(check);
});
};
Copy link
Member

@knowler knowler Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const domReady = (onReady) => {
window.requestAnimationFrame(function check() {
document.body ? onReady() : window.requestAnimationFrame(check);
});
};
export const domReady = (onReady) => {
window.requestAnimationFrame(document.body ? onReady : domReady);
}

We can check for the body immediately, right? Do we even need to do that in an animation frame the first time it’s called? I don’t know enough about window.requestAnimationFrame, so I could be wrong. (I am wrong, the falsy passed domReady in my suggestion loses the reference to onReady.)

As an aside, I think we should change the name of this function to bodyIsReady (alternatively prefixed with my), since it kind of breaks the mold of DOM readiness functions (particularly by going outside of the definition of DOMContentLoaded).

bud.config.js Outdated Show resolved Hide resolved
@retlehs retlehs merged commit 69dfbfc into master Nov 22, 2021
@QWp6t QWp6t deleted the roots-build-tools branch November 22, 2021 06:49
strarsis added a commit to strarsis/sage that referenced this pull request Jan 23, 2022
Scripts were accidentally removed in PR roots#2643.
retlehs pushed a commit that referenced this pull request Feb 8, 2022
Scripts were accidentally removed in PR #2643.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants