Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel Mix HMR feature compatibility #66

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Add Laravel Mix HMR feature compatibility #66

merged 1 commit into from
Aug 6, 2020

Conversation

LeoColomb
Copy link
Contributor

This little addition targets to provide support for Laravel Mix "native" Hot Module Replacement for all Acorn-based development.

"Native" means BrowserSync is no more required, neither any proxying tools.

Pros

  • Use all the power of webpack-dev-server via laravel-mix
  • Usage is really straightforward
    • No special/additional configuration
    • No additional dependencies
  • No more proxy required
    • The same address can be used with or without HMR
    • HMR handling script is added to build assets automatically
  • We can get rid of browsersync
  • The addition won't change anything if laraval-mix HMR is not used
  • The trait can be reused by any assets manifest class

Cons

  • By using this, we loose browsersync special features, like multi-tab management. (did we really use them? 😇)

@QWp6t QWp6t requested a review from Log1x June 11, 2020 19:09
@Log1x Log1x self-assigned this Jul 8, 2020
@Log1x Log1x added the enhancement New feature or request label Jul 8, 2020
@Log1x Log1x merged commit ef5bc9a into roots:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants