-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Automatically expose public properties and methods on View Composers #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Define the except property inside of the Composer class
🚚 Move the `Extractable` trait to `Roots\Acorn\View\Composers\Concerns`
🎨 Improve `defaultExcept` coverage 🎨 Use shorthanded functions in the Extractable trait where possible
…in a try/catch statement 📝 Improve the `Arrayable` docblock
QWp6t
reviewed
Dec 11, 2023
QWp6t
reviewed
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives Acorn's View Composers the same behavior as View Components exposing all public properties/methods automatically to the targeted view(s).
An added bonus to this is being able to easily invoke public methods using the variable inside a view such as
$example($post->ID)
.Most code is taken from Illuminate's Component.php and moved into a Trait.
This only takes effect when
with()
andoverride()
are empty thus maintaining backwards compatibility.Could use more testing.
Change log
$ignore
property to$except
in the View ComposerArrayable
trait