Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Pint to a specific version? #333

Closed
retlehs opened this issue Jan 25, 2024 · 0 comments
Closed

Pin Pint to a specific version? #333

retlehs opened this issue Jan 25, 2024 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@retlehs
Copy link
Member

retlehs commented Jan 25, 2024

Since we don't include a composer.lock file on this project and Laravel Pint is currently not pinned to a specific version, updates from Pint have resulted CI failures out of the blue:

https://github.com/roots/acorn/actions/runs/7465906223/job/20743042938?pr=329

If Pint continues to introduce changes like this in minor versions, then we might want to just pin the version. Applying the new formatting requirements to the codebase could potentially introduce conflicts with any open PRs.

@retlehs retlehs added the question Further information is requested label Jan 25, 2024
Log1x added a commit that referenced this issue Mar 18, 2024
@Log1x Log1x closed this as completed in 0e64acb Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants