Bug: enqueueCss() not working as expected

[tedw]

Terms

• I have read the guidelines for Contributing to Roots Projects
• This request is not a duplicate of an existing issue
• I have read the docs and followed them (if applicable)
• I have seached the Roots Discourse for answers and followed them (if applicable)
• This is not a personal support request that should be posted on the Roots Discourse community

Description

What's wrong?

enqueueCss() doesn’t work when there’s only a single CSS file as the entry point.

bud.entry({
  app: ['@scripts/main', '@styles/main.scss'],
  login: '@styles/login.scss'
})
  .splitChunks(false)
  .runtime(false)
  .assets('images')
  .watch('resources/views/**/*', 'app/**/*')
  .proxy('http://my-app-name.lndo.site')
  .serve('http://localhost:3000');

add_action('login_enqueue_scripts', function() {
    bundle('login')->enqueueCss();
});

What have you tried?

It works if you add another file to the login entry. It also works if you downgrade @roots/bud to version 5.8.3 and use enqueue() instead. However, starting at version 5.8.4 neither enqueueCss() nor enqueue() works when there is a single file.

What insights have you gained?

I suspect this Bud update below is reason why it’s failing, but I think the root cause is with Acorn.

• Issue JS file always generated even when no entry defined bud#1416
• PR 🐛 fix(patch): do not emit empty js assets bud#1417

Here’s the error message:

Here’s the relevant line in /app/vendor/roots/acorn/src/Roots/Acorn/Assets/Bundle.php:36

acorn/src/Roots/Acorn/Assets/Bundle.php

Line 136 in 53cba94

if (Arr::isAssoc($this->bundle['js'])) {

Possible solutions

I’m not super familiar with the codebase yet but I’m hoping it’s as easy as updating the line referenced above.

Temporary workarounds

Create an empty JS file and add it to the entry point:

bud.entry({
  app: ['@scripts/main', '@styles/main.scss'],
  login: ['@scripts/empty', '@styles/login.scss']
})

Another option is to downgrade to Bud 5.8.3 and use enqueue().

Steps To Reproduce

1. Add a single CSS as an entry point in bug.config.js
2. Attempt to enqueue that CSS file using bundle('example')->enqueueCss();
3. Run bud build
4. Open page that should have the custom CSS file in the browser

Expected Behavior

The CSS file should have been enqueued normally.

Actual Behavior

An error was thrown

Relevant Log Output

Fatal error: Uncaught Error: Argument 1 passed to Illuminate\Support\Arr::isAssoc() must be of the type array, null given, called in /app/vendor/roots/acorn/src/Roots/Acorn/Assets/Bundle.php on line 136
in /app/vendor/illuminate/collections/Arr.php on line 406

Call stack:

Illuminate\S\Arr::isAssoc()
/app/vendor/roots/acorn/src/Roots/Acorn/Assets/Bundle.php:136
Roots\A\A\Bundle::setRuntime()
/app/vendor/roots/acorn/src/Roots/Acorn/Assets/Bundle.php:36
Roots\A\A\Bundle::__construct()
/app/vendor/roots/acorn/src/Roots/Acorn/Assets/Manifest.php:56
Roots\A\A\Manifest::bundle()
/app/vendor/roots/acorn/src/Roots/helpers.php:36
Roots\bundle()
wp-content/themes/[redacted]/app/setup.php:19
App\{closure}()
wp-includes/class-wp-hook.php:307
WP_Hook::apply_filters()
wp-includes/class-wp-hook.php:331
WP_Hook::do_action()
wp-includes/plugin.php:476
do_action()
wp-login.php:114
login_header()
wp-login.php:1383

Versions

Sage 10, Acorn 2.0.6, Bud 5.8.0

[QWp6t]

Fixed in #230 (4fd1c43)