Support BESS protocol (for UML) #281

AkihiroSuda · 2022-01-05T09:29:05Z

BESS protocol transferrs L2 packets as AF_UNIX SOCK_SEQPACKET .
BESS protocol has been used by the vector network interfaces of User Mode Linux (UML).

(terminal 1) $ slirp4netns --target-type=bess /tmp/bess.sock
(terminal 2) $ linux.uml vec0:transport=bess,dst=/tmp/bess.sock,depth=128,gro=1 root=/dev/root rootfstype=hostfs init=/bin/bash mem=2G
(terminal 2: UML)$ ip addr add 10.0.2.100/24 dev vec0
(terminal 2: UML)$ ip link set vec0 up
(terminal 2: UML)$ ip route add default via 10.0.2.2

More docs about the User Mode Linux with BESS socket transport: https://www.kernel.org/doc/html/latest/virt/uml/user_mode_linux_howto_v2.html#bess-socket-transport

AkihiroSuda · 2022-01-05T09:29:17Z

cc @giuseppe @elmarco FYI

giuseppe

I am not familiar with BESS but the code LGTM

Just left two minor comments

giuseppe · 2022-01-05T11:42:47Z

main.c

    if (argc - optind < 2) {
        goto error;
    }
+    if (argc - optind > 2) {
+        // not an error, for preventing potential compatibility issue
+        printf("WARNING: too many arguments\n");


should this go to stderr?

We have been using stdout or printing WARNING messages (why? 😅 )

slirp4netns/main.c

Lines 563 to 604 in f2ae176

case _DEPRECATED_NO_HOST_LOOPBACK:

// There was no tagged release with support for --no-host-loopback.

// So no one will be affected by removal of --no-host-loopback.

printf("WARNING: --no-host-loopback is deprecated and will be "

"removed in future releases, please use "

"--disable-host-loopback instead.\n");

/* FALLTHROUGH */

case DISABLE_HOST_LOOPBACK:

options->disable_host_loopback = true;

break;

case _DEPRECATED_CREATE_SANDBOX:

// There was no tagged release with support for --create-sandbox.

// So no one will be affected by removal of --create-sandbox.

printf("WARNING: --create-sandbox is deprecated and will be "

"removed in future releases, please use "

"--enable-sandbox instead.\n");

/* FALLTHROUGH */

case ENABLE_SANDBOX:

options->enable_sandbox = true;

break;

case ENABLE_SECCOMP:

printf("WARNING: Support for seccomp is experimental\n");

options->enable_seccomp = true;

break;

case NETNS_TYPE:

optarg_netns_type = optarg;

break;

case USERNS_PATH:

optarg_userns_path = optarg;

if (access(optarg_userns_path, F_OK) == -1) {

fprintf(stderr, "userns path doesn't exist: %s\n",

optarg_userns_path);

goto error;

}

break;

case 'a':

optarg_api_socket = optarg;

break;

case '6':

options->enable_ipv6 = true;

printf("WARNING: Support for IPv6 is experimental\n");

break;

giuseppe · 2022-01-05T11:43:13Z

main.c

+    }
+
+    /* Accept a connection, and send its connection to the parent */
+    printf("Waiting for connection to %s\n", bess_socket);


we are using both stdout and stderr for diagnostic messages. Should we just stick to stderr?

BESS protocol transferrs L2 packets as AF_UNIX SOCK_SEQPACKET . BESS protocol has been used by the vector network interfaces of User Mode Linux (UML). ``` (terminal 1) $ slirp4netns --target-type=bess /tmp/bess.sock (terminal 2) $ linux.uml vec0:transport=bess,dst=/tmp/bess.sock,depth=128,gro=1 root=/dev/root rootfstype=hostfs init=/bin/bash mem=2G (terminal 2: UML)$ ip addr add 10.0.2.100/24 dev vec0 (terminal 2: UML)$ ip link set vec0 up (terminal 2: UML)$ ip route add default via 10.0.2.2 ``` More docs about the User Mode Linux with BESS socket transport: https://www.kernel.org/doc/html/latest/virt/uml/user_mode_linux_howto_v2.html#bess-socket-transport Signed-off-by: Akihiro Suda <[email protected]>

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda · 2022-01-06T06:59:06Z

Step 9/19 : RUN  git pull && git checkout ${LIBSLIRP_COMMIT} && meson setup build && ninja -C build install
 ---> Running in f5c0822a3dc4
fatal: unable to access 'https://gitlab.freedesktop.org/slirp/libslirp.git/': The requested URL returned error: 504
The command '/bin/sh -c git pull && git checkout ${LIBSLIRP_COMMIT} && meson setup build && ninja -C build install' returned a non-zero code: 1

😢
https://github.com/rootless-containers/slirp4netns/runs/4723883332?check_suite_focus=true

Use git://git.qemu.org/libslirp.git instead of https://gitlab.freedesktop.org/slirp/libslirp.git temporarily Signed-off-by: Akihiro Suda <[email protected]>

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda added this to the v1.2.0 milestone Jan 5, 2022

AkihiroSuda force-pushed the bess branch 4 times, most recently from a6527b3 to dbf96f1 Compare January 5, 2022 09:43

giuseppe approved these changes Jan 5, 2022

View reviewed changes

AkihiroSuda force-pushed the bess branch from d08e033 to fea6b9b Compare January 6, 2022 04:37

AkihiroSuda added 2 commits January 6, 2022 13:53

silence lint false positive (tapname == NULL)

1b32bbd

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda force-pushed the bess branch from fea6b9b to cdcac5b Compare January 6, 2022 04:53

AkihiroSuda added 3 commits January 6, 2022 17:56

[TMP] avoid HTTP error of gitlab.freedesktop.org

4bb41c7

Use git://git.qemu.org/libslirp.git instead of https://gitlab.freedesktop.org/slirp/libslirp.git temporarily Signed-off-by: Akihiro Suda <[email protected]>

v1.2.0-beta.0

477db14

Signed-off-by: Akihiro Suda <[email protected]>

v1.2.0-beta.0+dev

1aea545

Signed-off-by: Akihiro Suda <[email protected]>

AkihiroSuda force-pushed the bess branch from cdcac5b to 1aea545 Compare January 6, 2022 09:18

AkihiroSuda merged commit 95f3620 into rootless-containers:master Jan 6, 2022

AkihiroSuda mentioned this pull request Apr 27, 2022

v1.2 release ; v1.1 EOL #292

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support BESS protocol (for UML) #281

Support BESS protocol (for UML) #281

AkihiroSuda commented Jan 5, 2022

AkihiroSuda commented Jan 5, 2022

giuseppe left a comment

giuseppe Jan 5, 2022

AkihiroSuda Jan 6, 2022

giuseppe Jan 5, 2022

AkihiroSuda Jan 6, 2022

AkihiroSuda commented Jan 6, 2022

	case _DEPRECATED_NO_HOST_LOOPBACK:
	// There was no tagged release with support for --no-host-loopback.
	// So no one will be affected by removal of --no-host-loopback.
	printf("WARNING: --no-host-loopback is deprecated and will be "
	"removed in future releases, please use "
	"--disable-host-loopback instead.\n");
	/* FALLTHROUGH */
	case DISABLE_HOST_LOOPBACK:
	options->disable_host_loopback = true;
	break;
	case _DEPRECATED_CREATE_SANDBOX:
	// There was no tagged release with support for --create-sandbox.
	// So no one will be affected by removal of --create-sandbox.
	printf("WARNING: --create-sandbox is deprecated and will be "
	"removed in future releases, please use "
	"--enable-sandbox instead.\n");
	/* FALLTHROUGH */
	case ENABLE_SANDBOX:
	options->enable_sandbox = true;
	break;
	case ENABLE_SECCOMP:
	printf("WARNING: Support for seccomp is experimental\n");
	options->enable_seccomp = true;
	break;
	case NETNS_TYPE:
	optarg_netns_type = optarg;
	break;
	case USERNS_PATH:
	optarg_userns_path = optarg;
	if (access(optarg_userns_path, F_OK) == -1) {
	fprintf(stderr, "userns path doesn't exist: %s\n",
	optarg_userns_path);
	goto error;
	}
	break;
	case 'a':
	optarg_api_socket = optarg;
	break;
	case '6':
	options->enable_ipv6 = true;
	printf("WARNING: Support for IPv6 is experimental\n");
	break;

Support BESS protocol (for UML) #281

Support BESS protocol (for UML) #281

Conversation

AkihiroSuda commented Jan 5, 2022

AkihiroSuda commented Jan 5, 2022

giuseppe left a comment

Choose a reason for hiding this comment

giuseppe Jan 5, 2022

Choose a reason for hiding this comment

AkihiroSuda Jan 6, 2022

Choose a reason for hiding this comment

giuseppe Jan 5, 2022

Choose a reason for hiding this comment

AkihiroSuda Jan 6, 2022

Choose a reason for hiding this comment

AkihiroSuda commented Jan 6, 2022