Explicitly support DHCP + add tests+ update libslirp to v4.6.1 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giuseppe WDYT? Not really useful for containers, but this has been implemented since the beginning. Also, as a side-effect, |
AkihiroSuda
force-pushed
the
dev
branch
3 times, most recently
from
b970a28 to
e63f901
Compare
AkihiroSuda
changed the title
Close issue 124 The test should pass with libslirp < 4.6.0 and libslirp >= 4.6.1, but should fail with libslirp == 4.6.0 . https://gitlab.freedesktop.org/slirp/libslirp/-/issues/48 Signed-off-by: Akihiro Suda <[email protected]>
giuseppe
approved these changes
Jun 18, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #124
The test should pass with libslirp < 4.6.0 and libslirp >= 4.6.1, but should fail with libslirp == 4.6.0 .
https://gitlab.freedesktop.org/slirp/libslirp/-/issues/48