Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready-fd should not be activated until API socket is ready #90

Closed
AkihiroSuda opened this issue May 20, 2019 · 0 comments · Fixed by #97
Closed

ready-fd should not be activated until API socket is ready #90

AkihiroSuda opened this issue May 20, 2019 · 0 comments · Fixed by #97
Labels
bug Something isn't working
Milestone
v0.4.0

Comments

@AkihiroSuda
Copy link
Member

containers/podman#3162 (comment)
@AkihiroSuda AkihiroSuda added bug Something isn't working good first issue Good for newcomers labels May 20, 2019
@AkihiroSuda AkihiroSuda mentioned this issue May 20, 2019
Merged
AkihiroSuda added a commit to AkihiroSuda/slirp4netns that referenced this issue Jul 18, 2019
@AkihiroSuda
defer --ready-fd activation until everything is ready
9115b34 
Previously, --ready-fd was written when the network configuration (-c)
is ready, but at that time the API socket was not ready to use.

Fix rootless-containers#90

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda mentioned this issue Jul 18, 2019
Merged
@AkihiroSuda AkihiroSuda removed the good first issue Good for newcomers label Jul 18, 2019
@AkihiroSuda AkihiroSuda added this to the v0.4.0 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

defer --ready-fd activation until everything is ready AkihiroSuda/slirp4netns
1 participant
@AkihiroSuda