Fix up privileged port exposure #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is showing up looking like podman run -p 80:80 fedora echo hello Error: failed to expose ports via rootlessport: "cannot expose privileged port 80, you might need to add \"net.ipv4.ip_unprivileged_port_start=0\" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied\n" When run in Podman, trying to clean it up a little so the special chars \" to not show up, and I think it makes more senset to tell users to start have priv port, at least from a security point of view. Users probably want to keep this above port 22. net.ipv4.ip_unprivileged_port_start=80 Rather then net.ipv4.ip_unprivileged_port_start=0 Signed-off-by: Daniel J Walsh <[email protected]>
|
Released v0.11.1 with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is showing up looking like
podman run -p 80:80 fedora echo hello
Error: failed to expose ports via rootlessport: "cannot expose privileged port 80, you might need to add "net.ipv4.ip_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied\n"
When run in Podman, trying to clean it up a little so the special chars " to
not show up, and I think it makes more senset to tell users to start have priv
port, at least from a security point of view. Users probably want to keep this above port 22.
net.ipv4.ip_unprivileged_port_start=80
Rather then
net.ipv4.ip_unprivileged_port_start=0
Signed-off-by: Daniel J Walsh [email protected]