io rules: test with array input followed by other inputs #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @pcanal; you invoked me (as reviewer), so here's the review (taking into account context from sibling root PR)! Other than that, it LGTM!
Hope everything is going well at CERN / Fermilab - and Happy New 2025 🎉!
Comment on lines
+278
to
+279
| template<size_t N, typename V> // = decltype(T::f)[N]> | ||
| bool check_array(int arr[N], V ref) |
There was a problem hiding this comment.
I guess that we could make the two parameters of the same type (esp. given that they are being compared 1-to1 below), right?
| @@ -454,6 +514,9 @@ int readfile(const char *filename = "sourcetypes.root") | |||
| res = res && check(n->fListExplicit, {"b1", "b2", "b3"}); | |||
| res = res && check(n->fListImplicitExplicit, {"c1", "c2", "c3"}); | |||
|
|
|||
| res = res && check_array<3>(n->fHitPattern, std::vector<int>{111, 112, 113}); | |||
There was a problem hiding this comment.
Possibly use initializer list or std::array<int, 3> instead.
Suggested change
| res = res && check_array<3>(n->fHitPattern, std::vector<int>{111, 112, 113}); | |
| res = res && check_array<3>(n->fHitPattern, std::initializer_list<int>{111, 112, 113}); |
Comment on lines
+126
to
+127
| std::cout << "The double"; | ||
| std::cout << " value is: " << a; |
There was a problem hiding this comment.
Why double; isn't that an int?
Suggested change
| std::cout << "The double"; | |
| std::cout << " value is: " << a; | |
| std::cout << "The integer value is: " << a; |
|
thanks @jalopezg-git !!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR to root-project/root#17523