Implement SetStats for TGraph. #8498
Conversation
|
Starting build on |
| @@ -67,6 +67,7 @@ class TGraph : public TNamed, public TAttLine, public TAttFill, public TAttMarke | |||
| public: | |||
| // TGraph status bits | |||
| enum EStatusBits { | |||
| kNoStats = BIT(9), ///< Don't draw stats box | |||
There was a problem hiding this comment.
Did you check that the BIT(9) doesn't conflict in the parent class(es)? I.e. BIT(9) could already be used by any of the TNamed, TAttLine, TAttFill, TAttMarker classes
There was a problem hiding this comment.
Yes, I checked it is used in TH1 for exactly the same thing
There was a problem hiding this comment.
I looked in TGraph.cxx the other bits are not initialised in the constructors. There is only two calls to ResetBit and that's not in the constructors.:
hist/src/TGraph.cxx: const_cast <TGraph*>(this)->ResetBit(kResetHisto);
hist/src/TGraph.cxx: if (editable) ResetBit(kNotEditable);
I guess the BIT are initialised elsewhere. The behaviour I get is correct.i It is backward compatible.
couet
requested review from
bellenot
and removed request for
Axel-Naumann and
lmoneta
As requested here: https://root-forum.cern.ch/t/remove-stats-box-from-fitted-tgraph/45490