-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of test/stressMathCore.cxx to use Google Test #594
Refactor of test/stressMathCore.cxx to use Google Test #594
Conversation
Basic refactoring of test/stressMathCore.cxx to be smaller, more managable files, and to use Google Test. The functionality is the same, but is now using Google Test for assertions instead of doing logical operations on an integer as the test result. Added test as Google Test Formatting, cleanup Assertions from Google Test Split up functions Removed timer and decoupled tests Decoupled GenVector Decoupled testSMatrix/testVector34 Decoupled SMatrixTest Assertions Removed dead/useless code Use google test instead of c++ assertions Clang-format Moved stress test to stress folder Clang format Split up files Split up files Removed blob file after split up Clang-format Renamed fields, methods, macros Punctuation Added header Fixed warning Resolved dictionary issues Fixed typo Proper naming of function names
Starting build on |
It seems there are a few clang-format and clang-tidy issues. Could you address them, too? |
Starting build on |
@vgvassilev Fixed in commit 6cf326d, thanks. |
What about the clang-tidy issue? |
@vgvassilev Sorry, I thought it was fixed as the build passed so I didn't dive into the console logs of it. Anyhow, as far as I understand, the only issue it complains about is that |
It comes from an 'alpha' checker and think it is a false positive. |
Basic refactoring of test/stressMathCore.cxx to be smaller, more manageable files, and to use Google Test. The functionality is the same, but is now using Google Test for assertions instead of doing logical operations on an integer as the test result.
Ping @lmoneta