Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of test/stressMathCore.cxx to use Google Test #594

Merged
merged 3 commits into from
May 31, 2017
Merged

Refactor of test/stressMathCore.cxx to use Google Test #594

merged 3 commits into from
May 31, 2017

Conversation

martinmine
Copy link
Contributor

@martinmine martinmine commented May 30, 2017

Basic refactoring of test/stressMathCore.cxx to be smaller, more manageable files, and to use Google Test. The functionality is the same, but is now using Google Test for assertions instead of doing logical operations on an integer as the test result.

Ping @lmoneta

Basic refactoring of test/stressMathCore.cxx to be smaller, more
managable files, and to use Google Test. The functionality is the same,
but is now using Google Test for assertions instead of doing logical
operations on an integer as the test result.

Added test as Google Test

Formatting, cleanup

Assertions from Google Test

Split up functions

Removed timer and decoupled tests

Decoupled GenVector

Decoupled testSMatrix/testVector34

Decoupled SMatrixTest

Assertions

Removed dead/useless code

Use google test instead of c++ assertions

Clang-format

Moved stress test to stress folder

Clang format

Split up files

Split up files

Removed blob file after split up

Clang-format

Renamed fields, methods, macros

Punctuation

Added header

Fixed warning

Resolved dictionary issues

Fixed typo

Proper naming of function names
@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@vgvassilev
Copy link
Member

It seems there are a few clang-format and clang-tidy issues. Could you address them, too?

@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@martinmine
Copy link
Contributor Author

@vgvassilev Fixed in commit 6cf326d, thanks.

@vgvassilev
Copy link
Member

What about the clang-tidy issue?

@martinmine
Copy link
Contributor Author

@vgvassilev Sorry, I thought it was fixed as the build passed so I didn't dive into the console logs of it. Anyhow, as far as I understand, the only issue it complains about is that root/math/mathcore/test/stress/TestHelper.cxx:33:20 is never reached, which I find unreasonable. Do you think this could be a false flag, or something I should look more into?

@vgvassilev
Copy link
Member

It comes from an 'alpha' checker and think it is a false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants