[cling] Handle the case if the plugin is passed as a shared object. #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
Build failed on windows10/vc15. |
When cling is embedded and the plugins are linked statically we can rely on the initialization of the Preprocessor to register the pragmas. Currently, due to the current implementation deficiency we cannot rely on the same mechanism when loading the plugins as shared objects. This patch fixes the failing cling test.
vgvassilev
force-pushed
the
fix_cling_plugin_tests
branch
from
b105a44 to
0cb5744
Compare
|
Starting build on |
|
Build failed on ROOT-centos7/noimt. Errors:
|
|
@phsft-bot build just on fedora29/python3 with flags -Dclingtest=On |
|
@phsft-bot build just on fedora29/python3 with flags -Dclingtest=On |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cling is embedded and the plugins are linked statically we can rely
on the initialization of the Preprocessor to register the pragmas.
Currently, due to the current implementation deficiency we cannot rely
on the same mechanism when loading the plugins as shared objects.
This patch fixes the failing cling test.