Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reve] Correct secondary selection in RC.RendeQuTor. #16418

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

alja
Copy link
Collaborator

@alja alja commented Sep 12, 2024

The RenderCore changes introduced a bug in the secondary selection.

The change was created with the PR #15812.

Temprary solution is that the GLViewerRCore.js overrides RenderQuTor pick function.

The related change is pending in RenderCore UL-FRI-LGM/RenderCore#21

@alja alja requested a review from linev as a code owner September 12, 2024 18:21
@linev linev self-assigned this Sep 12, 2024
@alja
Copy link
Collaborator Author

alja commented Sep 12, 2024

@linev @osschar Please check.
I will back-port the change in the patches branch.

Copy link

Test Results

    13 files      13 suites   3d 0h 53m 54s ⏱️
 3 029 tests  3 028 ✅ 0 💤 1 ❌
33 856 runs  33 855 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 7b509a1.

@linev linev merged commit eaf6622 into root-project:master Sep 13, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants